worker: strip types in Web Worker module entries - #66085
Open
osztenkurden wants to merge 1 commit into
Open
osztenkurden wants to merge 1 commit into
osztenkurden wants to merge 1 commit into
Conversation
Strip TypeScript from file-backed module worker entries before evaluating the fetched source. Add regression coverage and document the supported entry types. Assisted-by: Codex Signed-off-by: Hubert Walczak <hubertwalczak8@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66085 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 789 789
Lines 271623 271642 +19
Branches 51847 51860 +13
==========================================
+ Hits 245196 245250 +54
+ Misses 16910 16861 -49
- Partials 9517 9531 +14
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental Web Worker module entries don't perform TypeScript stripping: type annotations in the entry file cause a SyntaxError, even though a JavaScript-compatible entry importing files with TypeScript annotations succeeds.
The proposed solution is to strip types from file-backed .ts, .mts, and .cts module-worker entries before evaluation, preserving existing fetching and worker-type semantics.