Conversation
Move the permission drop test to the FFI suite so test-ci-js does not require the native FFI fixture library. Update the helper import to match the new location. Synchronize the Windows native suites with the Makefile by including ffi. Build its fixture for test-ci-native, but not for test-ci-js. Fixes: nodejs#66055 Refs: nodejs#63165 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
inoway46
marked this pull request as ready for review
September 16, 2026 11:07
richardlau
approved these changes
Sep 16, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66059 +/- ##
==========================================
- Coverage 90.27% 90.25% -0.03%
==========================================
Files 789 789
Lines 271465 271465
Branches 51812 51806 -6
==========================================
- Hits 245063 245002 -61
- Misses 16884 16929 +45
- Partials 9518 9534 +16 🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 17, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-permission-drop-ffirequires a native fixture but runs in the JS suite, causingmake test-ci-jsto fail when the fixture is absent.Move it to
test/ffi, consistent with #63165. Addffito WindowsNATIVE_SUITESand remove its fixture build from Windowstest-ci-js, retaining it fortest-ci-native.Fixes: #66055
Refs: #62672
Refs: #63165