Conversation
Member
Author
|
@nodejs/diagnostics wdyt? Should we do this or should we have one event for each operation? |
jasnell
reviewed
Aug 18, 2026
| if (!path.empty()) { | ||
| obj->Set(context, | ||
| env->path_string(), | ||
| String::NewFromUtf8(isolate, |
Member
|
SGTM |
Contributor
|
Does this impact perf. much when the channels are not subscribed to? Depending on the impact with a subscriber it might be worth having a channel per operation so that we can be selective over which ops we want to impact? |
Contributor
|
I think having granularity via multiple channels is better because it allows APMs to choose what to subscribe to without adding overhead to NO-OP events. |
mcollina
force-pushed
the
fs-diagnostics-channel
branch
from
August 28, 2026 18:17
657db86 to
508ffc0
Compare
Add built-in node:diagnostics_channel channels for file system operations performed through node:fs and node:fs/promises. Each operation gets its own TracingChannel family named fs.<operation>, with channels tracing:fs.<operation>:start, :end, :asyncStart, :asyncEnd, and :error. The event payload carries the API (sync/callback/promise), path/dest/fd fields when applicable, plus result/error following TracingChannel conventions. Events are published from the internal shared file system layer rather than the JS wrappers, so captured function references still emit events. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fs-diagnostics-channel
branch
from
September 5, 2026 14:17
508ffc0 to
6e1aa61
Compare
mcollina
marked this pull request as ready for review
September 17, 2026 08:09
Define the inline channel helpers in node_file-inl.h so that including node_file.h alone builds under -Werror=undefined-inline. Hold the cached channels weakly, as the permission code does, and skip the instrumentation while building a snapshot: linking a native channel creates JS channel objects that cannot be serialized. Signed-off-by: Matteo Collina <hello@matteocollina.com>
The libuv request's file field is private and a union on Windows, so reading it does not compile there. Every descriptor-based libuv fs operation takes the descriptor as its first argument, so pick it up from the call arguments instead. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65370 +/- ##
==========================================
+ Coverage 90.19% 90.26% +0.06%
==========================================
Files 770 789 +19
Lines 264410 271799 +7389
Branches 50243 51879 +1636
==========================================
+ Hits 238479 245333 +6854
+ Misses 16926 16919 -7
- Partials 9005 9547 +542
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds built-in
node:diagnostics_channelchannels for file system operations performed throughnode:fsandnode:fs/promises, addressing #65330.Each operation gets its own
TracingChannelfamily namedfs.<operation>(e.g.fs.open,fs.read,fs.stat), with channelstracing:fs.<operation>:start,:end,:asyncStart,:asyncEnd, and:error. The event payload carries the API (sync/callback/promise),path/dest/fdfields when applicable, plusresult/errorfollowing TracingChannel conventions. Subscribers can usediagnostics_channel.tracingChannel('fs.open')to subscribe to all events of one operation at once, or subscribe to individual channels by name.Events are published from the internal shared file system layer rather than the JS wrappers, so captured function references still emit events. Adds documentation and a new
test/parallel/test-diagnostics-channel-fs.js.AI generated, humanly reviewed.