Skip to content

test: mark test-http2-large-file flaky on aix - #47410

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky
Closed

test: mark test-http2-large-file flaky on aix#47410
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky

Conversation

@MoLow

@MoLow MoLow commented Apr 4, 2023

Copy link
Copy Markdown
Member

a mitigation for #47409

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 4, 2023
@MoLow MoLow added fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 4, 2023
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 4, 2023
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50934/

@MoLow MoLow removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 4, 2023
mhdawson
mhdawson approved these changes Apr 4, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50944/

@github-actions github-actions Bot mentioned this pull request Apr 5, 2023
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50949/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50954/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50970/

@anonrig

anonrig commented Apr 5, 2023

Copy link
Copy Markdown
Member

Could we land this manually? The tests are failing because of a different issue.

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50987/

@targos

targos commented Apr 6, 2023

Copy link
Copy Markdown
Member

#47450 should make this unnecessary.

@MoLow

MoLow commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

closing in favor of #47450

@MoLow MoLow closed this Apr 6, 2023
@MoLow
MoLow deleted the mark-http2-large-file-as-flaky branch April 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow @nodejs-github-bot @anonrig @targos @mhdawson