Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
37.3k
Star
122k
Code
Issues
623
Pull requests
552
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
tools, test: forbid string literal as third argument for assert.strictEqual() and friends
- #22849
#22849
Closed
Trott
wants to merge 12 commits into
nodejs:master
nodejs/node:master
from
Trott:strictequal-literal
Trott/io.js:strictequal-literal
Copy head branch name to clipboard
Conversation
Commits
12
(12)
Checks
Files changed
Closed
tools, test: forbid string literal as third argument for assert.strictEqual() and friends
#22849
Trott
wants to merge 12 commits into
nodejs:master
nodejs/node:master
from
Trott:strictequal-literal
Trott/io.js:strictequal-literal
Copy head branch name to clipboard
Commits
Commits on Sep 13, 2018
test: remove string literal message from assertion
Show description for abcaf56
Trott
committed
abcaf56
View commit details
Copy full SHA for abcaf56
Browse repository at this point
test: remove string literal message in assertions
Show description for 486f6e8
Trott
committed
486f6e8
View commit details
Copy full SHA for 486f6e8
Browse repository at this point
test: improve assertion in test-inspector.js
Show description for 890c455
Trott
committed
890c455
View commit details
Copy full SHA for 890c455
Browse repository at this point
test: simplify assertion in http2 tests
Show description for d65e189
Trott
committed
d65e189
View commit details
Copy full SHA for d65e189
Browse repository at this point
test: refactor flag check
Show description for b23cb6c
Trott
committed
b23cb6c
View commit details
Copy full SHA for b23cb6c
Browse repository at this point
test: remove string literal from assertion
Show description for 36769be
Trott
committed
36769be
View commit details
Copy full SHA for 36769be
Browse repository at this point
test: remove string literal message from assertion
Show description for 26f2e99
Trott
committed
26f2e99
View commit details
Copy full SHA for 26f2e99
Browse repository at this point
test: remove string literal arg from assertion
Show description for 798a6dd
Trott
committed
798a6dd
View commit details
Copy full SHA for 798a6dd
Browse repository at this point
test: remove string literal from assertion
Show description for af1f7c7
Trott
committed
af1f7c7
View commit details
Copy full SHA for af1f7c7
Browse repository at this point
test: remove string literal from assertion
Show description for 8572e6e
Trott
committed
8572e6e
View commit details
Copy full SHA for 8572e6e
Browse repository at this point
test: prepare test-assert for strictEqual linting
Show description for 4b9142c
Trott
committed
4b9142c
View commit details
Copy full SHA for 4b9142c
Browse repository at this point
tools: prevent string literals in some assertions
Show description for 51cd1ea
Trott
committed
51cd1ea
View commit details
Copy full SHA for 51cd1ea
Browse repository at this point
You can’t perform that action at this time.