fix(base64, hex): enhance decoding to ignore non-Latin1 characters - #17
Open
mertcanaltin wants to merge 1 commit into
Open
mertcanaltin wants to merge 1 commit into
mertcanaltin wants to merge 1 commit into
Conversation
lemire
approved these changes
Sep 15, 2026
lemire
left a comment
Member
There was a problem hiding this comment.
This looks good to me.
Note that this will affect end users in the sense that some
Member
Author
Thanks, I will note on node update PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes wrong output from the base64 and hex decoders for non-Latin1 characters.