Adding Brotli Support - #598
Conversation
|
Thx for the PR, I will into merging it. Just one request: could you change the tests to use |
|
Seems like "should ignore invalid headers" test gone wrong in Node 12 @bitinn .
|
|
@hlthi I suspect node 12 has changed how they handle invalid headers, so this test now fails on The PR itself looks good, but I will need to fix the node 12 issue first. |
Possible problems
Debug err{
"bytesParsed": 171,
"code": "HPE_INVALID_HEADER_TOKEN",
"reason": "Invalid header value char"
}Investigate in LLHTTP, LLHTTP waiting \r and \n ; but show \x07 and boom. I try on macOS mojave with node 12 $ npm version | grep http_parser
http_parser: '2.8.0', |
|
thx for the PR, released as 2.4.0 |
Native support
Node Documentation