fix: send Referer header for strict-origin referrer policy - #1912
Closed
marceli1404 wants to merge 1 commit into
Closed
marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: The Referer header is never sent when referrerPolicy strict-origin is used, even though the spec requires it when referrer URL and current URL are both potentially trustworthy.
Root cause: in determineRequestsReferrer (src/utils/referrer.js), the strict-origin case returns referrerOrigin.toString() (a String), while every other policy returns the URL object. The header is sent from getNodeRequestOptions only when request referrer is instanceof URL, so the string fails the check and the Referer header is dropped.
Fix: return the referrerOrigin URL object in the strict-origin case, matching the spec step and every other policy.
Verification: