Check curl regex state - #2014
Merged
RincewindsHat merged 4 commits intoOct 6, 2024
Merged
RincewindsHat merged 4 commits into
RincewindsHat merged 4 commits into
Conversation
The help output of `check-curl` contained a typo, the real option is `state-regex` and not `regex-state` as the help suggests. Also added the two possible options to avoid confusion.
Previously the --state-regex option accepted only "critical" and "warning" as values. This commit changes the strcmp there to strcasecmp to be more tolerant regarding the input.
andreasbaumann
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for fixing all the things I left out.. :-)
Member
Author
|
@andreasbaumann would you like to press the "approve" button? :-) |
andreasbaumann
approved these changes
Oct 6, 2024
andreasbaumann
left a comment
Contributor
There was a problem hiding this comment.
approving (thats a more than just a button) ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly fixes a problem introduced in #2006 ( f29785f ), where the option really is
state-regexbut the help saysregex-state.