New output infrastructure - #1979
Closed
RincewindsHat wants to merge 37 commits into
Closed
RincewindsHat wants to merge 37 commits into
RincewindsHat wants to merge 37 commits into
Conversation
Member
Author
|
Also, sorry @sni, this is likely going in your direction. |
RincewindsHat
force-pushed
the
output_stuff
branch
from
January 3, 2024 17:22
7c2b1eb to
5fad1da
Compare
RincewindsHat
marked this pull request as ready for review
February 15, 2024 02:07
Member
Author
|
building block for a solution to #1098 |
Member
Author
|
starting point for #1416 |
Member
Author
|
replaced by #2064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a lot of new stuff to
libpart which is mostly related to generating the results.The idea is, that a plugin has a main result object (of type
mp_check) to which you add partial results, called subchecks (mp_subcheck).This
mp_subchecks can also containmp_subchecks, so you have a tree of results.Ideally we remove all of that specific logic/string handling and so on from the individual plugins, which would reduce complexity (in the plugins).
Also this would open the path to centrally structure and format output, which would be cool for me, since I have a hard time regarding the output of some plugins (cough
check_disk).The handling would be something like
No plugin was changed here, the functionality is implemented in
parallel to the existing stuff (mostly), so it can be included
and plugins can be adapted incrementaly following that (which I plan to do).
Problems