New general output functions for checks - #1483
sven-ruess wants to merge 13 commits into
Conversation
|
I do not know, why the tests for ping failed. I did not modify anything, which will be related to this issue. Perhaps you can trigger a restart for this test. I should be finished successful. |
|
I triggered a recheck of the travis build. |
|
Thank you. Now the tests are all successfully finished. Now you can have a look on the code. On the weekend I will adapt netutils and sslutils to use this new functions. For that I will create new branches from this current branch. |
- Simplified string helper functions
|
It looks like, that your tests have some timing issues. I only optimized my code a little bit and the tests fail again. Can you give me a short introduction, how I can get your tests running locally? I followed the steps of developer and user guide but most of the tests are failing. Do I have to setup a special environment or services? |
6e3e234 to
a01d24b
Compare
1280aed to
812f466
Compare
1f6a23e to
2becfd1
Compare
|
this might be a little late, but it sounds interesting and I might take a look at that in the future. |
|
Sorry for the lack of feedback on this. And implemented a different design with #2064 and want to go forward with. |
Dear Monitoring Team,
I had a look at your checks and they are working great. I will introduce a new software, which the monitoring plugins will be one part of it. I have written some test cases for my own software and got some troubles. I have implemented my interpretation of the result to the general output specification: SERVICE STATUS: First line of output|First part of performance data|Second part of performance data
or
SERVICE STATUS: First line of output|First part of performance data|Second part of performance data
Third part of performance data|Fourth part of performance data ...
Some of the checks I have tested, does not take care about this behaviour. So I checked the code and tried to find the problem. I was successful and had a great look into the code from you.
As a general solution for this problem, I have done the following steps:
Will print the output and returns to caller
Will print the output, returns the service_state as a return value and returns to caller
Will print the output and exits program with service_state
The first step is to get this new function accepted by you.
After that, my next steps will be the following:
Best regards
Sven