MRG: Use JUnit on CircleCI - #6008
Merged
Merged
Conversation
larsoner
force-pushed
the
junit
branch
3 times, most recently
from
March 1, 2019 12:52
e49fff2 to
b492af9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6008 +/- ##
==========================================
+ Coverage 87.32% 88.91% +1.59%
==========================================
Files 401 401
Lines 72844 72844
Branches 12109 12109
==========================================
+ Hits 63608 64769 +1161
+ Misses 6390 5193 -1197
- Partials 2846 2882 +36 |
Member
Author
|
JUnit says that the SPoC example took 5 minutes to run: https://circleci.com/gh/mne-tools/mne-python/11642 Ready for review/merge from my end. |
Member
|
it's a regression as it's much faster on 0.17
I think it's related to the refactoring of the whitening code.
… |
Member
Author
|
Okay let's fix that separately |
Member
|
ok to merge when rebased and CIs are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if sphinx-gallery/sphinx-gallery#454 makes things better for us.