fix: force http/1.1 ALPN on secure web proxy outer TLS - #8435
Open
asaf-shitrit wants to merge 4 commits into
Open
asaf-shitrit wants to merge 4 commits into
asaf-shitrit wants to merge 4 commits into
Conversation
The existing test builds the layer stack by hand, which is how the `len(context.layers) == 2` guard went stale unnoticed. This one runs Proxyserver with TlsConfig, connects with a client offering h2,http/1.1, and checks that the outer TLS gets http/1.1 while the inner TLS through the CONNECT tunnel still gets h2.
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continues #8204 (commit kept, @emanuele-em as author) and adds the behavioral test from review. A TLS client offering
h2,http/1.1getshttp/1.1on the outer handshake andh2on the inner TLS through the tunnel. Onmainthe first assertion fails.server.address is Noneholds for the outer handshake in both explicit modes, becausehandle_connectsets it before the tunneled TLS and upstream mode leaves it unset until the first request. The extra conditions proposed in #8192 add nothing beyond the existing client assert and this check.Not changed here: after CONNECT on a secure web proxy,
NextLayerkeys on the outerclient.alpnand picksHttpLayerfor the tunnel, so raw TCP through the tunnel stalls.Closes #8192
Supersedes #8204
Checklist