Show HTTP reason phrases for HTTP/2 and HTTP/3 via lookup table (issue #7694) - #8424
Open
Larslllllll wants to merge 3 commits into
Open
Larslllllll wants to merge 3 commits into
Larslllllll wants to merge 3 commits into
Conversation
…mitmproxy#7694) Adds statusCodeReasons lookup table (auto-generated from status_codes.py) and uses it in HttpMessages ResponseLine to show reason phrases for HTTP/2 and HTTP/3 responses. These are looked up from the status code since HTTP/2 and HTTP/3 do not transmit reason phrases on the wire. Includes a title tooltip explaining this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show reason phrases for HTTP/2 and HTTP/3 responses in the mitmweb flow view by looking them up from a status code table. These are not transmitted on the wire per RFC 7540 (HTTP/2) and RFC 9113 (HTTP/3), so a lookup table provides the human-readable reason.
Changes
web/gen/status_codes.py: A Python script that convertsmitmproxy/net/http/status_codes.pyto a TypeScript status code → reason phrase mapping.web/src/js/statusCodes.ts: Generated TypeScript file withexport const statusCodeReasons: Record<number, string>.web/src/js/components/FlowView/HttpMessages.tsx:statusCodeReasonsResponseLineto show looked-up reason for HTTP/2 and HTTP/3Details
statusCodeReasons[status_code]since the wire format omits it.Testing
Closes the RFC task from #7694.
Co-authored-by: web/gen/status_codes.py