Generated v1.0 models and request builders using Kiota - #36
github-actions[bot] wants to merge 1 commit into
Conversation
|
Closing this PR. We will not be updating models this week |
| @@ -1,2 +1,2 @@ | |||
| export * from './archiveRequestBody' | |||
| export * from './archiveResponse' | |||
| export * from './archiveRequestBody' | |||
There was a problem hiding this comment.
Vincent Biret (@baywet) Nikitha Chettiar (@nikithauc) is it possible an unordered set/map/list is being used when generating export statements? Replacing it with an ordered data structure should prevent unnecessary diffs
There was a problem hiding this comment.
I think that with the latest changes the only ordering that's applied is inheritance ordering, but that's it.
The ordering logic probably an additional ThenBy(x => x.Name) to be able to deterministically generate those.
|
Ronald K (@rkodev) what's the rationale behind not updating the sdk weekly? we're setup for it and we should use that preview time to build experience and get good at releasing weekly. |
|
Vincent Biret (@baywet) skipping updating the model this week since we have some manually modified files here #29 This should be resolved by addressing this ticket #33 This is only for the current week |
|
ok thanks for the detailed explanation here! |
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is 683ad12.
Important Check for unexpected deletions or changes in this PR.