docs(contributing): install browsers before running tests - #3199
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
The documented sequence went from building the wheel straight to pytest --browser chromium, but the browsers are never installed. CI does it explicitly at ci.yml lines 100, 147 and 178; the contributor path did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdtakes a contributor frompip install -e .andpython -m build --wheelstraight topytest --browser chromium. The browsers are never installed, andplaywright installdoes not appear anywhere inCONTRIBUTING.mdorREADME.md.CI does install them, explicitly, at three places in
.github/workflows/ci.yml:So the step is real and known, it just lives only in the workflow. Nothing in
conftest.pyorsetup.pyinstalls browsers on the contributor's behalf.I used plain
playwright install chromiumrather than CI's--with-deps, since that flag installs system packages and wants root on Linux, which is right for a runner and wrong as the default line in a contributor doc.Verified by reading the tree and the workflow. I did not run the suite on this machine, so I am not claiming a specific pytest error string, only that the documented path never installs what the test command needs.