This repository was archived by the owner on Jan 15, 2025. It is now read-only.
cross-train core library in bf-lu - #601
Merged
Merged
Conversation
This reverts commit ab1fb84.
…tframework-cli into feich/QnACrossTrain
Fei Chen (feich-ms)
requested review from
Dong Lei (boydc2014),
Emilio Munoz (munozemilio) and
Vishwac Sena Kannan (vishwacsena)
February 25, 2020 02:11
Vishwac Sena Kannan (vishwacsena)
suggested changes
Feb 25, 2020
Vishwac Sena Kannan (vishwacsena)
left a comment
Contributor
There was a problem hiding this comment.
We should do two things -
- Remove CLI tests from BF-LU
- Add tests that directly use the API surface.
For now, since there isn't a public API in R8, we should just move CLI tests to the cross-train branch and just add few sanity tests here for the classes and methods.
Contributor
Author
|
Vishwac Sena Kannan (@vishwacsena) working on the test refactoring. Will give updates when ready. |
Contributor
Author
|
Vishwac Sena Kannan (@vishwacsena), cross train core library related tests are refactored. The PR is ready and looks much more clean now. |
Vishwac Sena Kannan (vishwacsena)
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.