Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Fix expression visitor to make escape work in nested entity definition - #1106

Merged
Fei Chen (feich-ms) merged 2 commits into
mainfrom
feich/FixExpressionLexer
Feb 5, 2021
Merged

Fix expression visitor to make escape work in nested entity definition#1106
Fei Chen (feich-ms) merged 2 commits into
mainfrom
feich/FixExpressionLexer

Conversation

@feich-ms

@feich-ms Fei Chen (feich-ms) commented Feb 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #1107. Fix expression visitor logic to make escape work in nested entity definition, typical cases are:

# BoldIntent
- {@Command={@Action={@BoldAction=bold}} \{{@ActionTargetPhrase=directions from seattle to portland}\}},
- {@Command={@Action={@BoldAction=emphasise from}} {@ActionTargetRange={@ActionTargetStart=@username {@ActionTargetSeparator=through} {@ActionTargetEnd==}}}

After the fix, the escape brackets in nested brackets will work and the equal sign as entity value will also work.

@feich-ms
Fei Chen (feich-ms) merged commit fe56306 into main Feb 5, 2021
@feich-ms
Fei Chen (feich-ms) deleted the feich/FixExpressionLexer branch February 5, 2021 06:57
@feich-ms Fei Chen (feich-ms) mentioned this pull request Feb 8, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@munozemilio Emilio Munoz (munozemilio) Awaiting requested review from munozemilio
1 more reviewer
@boydc2014 Dong Lei (boydc2014) boydc2014 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape brackets in nested entity definition not work

2 participants

@feich-ms @boydc2014