This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Hash line ending agnostic and import exclusion bug - #1095
Merged
Merged
Conversation
Fix bug where imports were not excluded properly. Added obj to exclusions.
Chris McConnell (chrimc62)
requested a review
from Emilio Munoz (munozemilio)
as a code owner
January 23, 2021 01:57
Emilio Munoz (munozemilio)
approved these changes
Jan 25, 2021
Emilio Munoz (munozemilio)
left a comment
Contributor
There was a problem hiding this comment.
Should we add a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made hash computation line ending agnostic by normalizing to plain line feed. On CRLF systems this may result in a different hash than before. We always write OS.EOL, but git might change the line endings so this change was made.
Fix bug where imports were not excluded properly if they were relative paths. As a work-around people can add !/imported/ to their command line.
Added obj to default exclusions.