Skip to content

Add the DevFlow PR repair entrypoint - #8622

Merged
Evan Mattson (moonbox3) merged 2 commits into
microsoft:mainfrom
moonbox3:devflow-fix-ci
Sep 22, 2026
Merged

Evan Mattson (moonbox3) merged 2 commits into
microsoft:mainfrom
moonbox3:devflow-fix-ci

Conversation

@moonbox3

@moonbox3 Evan Mattson (moonbox3) commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

Allow team members to request scoped PR repairs with /fix-ci or /fix <instructions> through the configured DevFlow automation.

Description & Review Guide

  • What are the major changes? Adds one dispatch entrypoint workflow. It freezes the PR revision and command, authorizes the frozen requester using the existing team-membership helper, then dispatches the snapshot and pinned controller revision to DevFlow.
  • What is the impact of these changes? Repair orchestration, verification, approval, publication, and their tests live in DevFlow. Existing shared authorization helpers remain unchanged. Deploy the matching DevFlow pipeline before enabling this entrypoint.
  • What do you want reviewers to focus on? The immutable request snapshot, team gate before private repository access, and dispatch bindings.

Related Issue

None.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): 0b4146185a4b
Model: gpt-5.6-sol-fast

Overview

The repair pipeline has strong request binding, authorization, artifact-digest checks, credential separation, and container isolation. However, verification still executes PR-controlled build configuration, does not require replacement files to be covered by the selected verification targets, and cannot publish to the fork branches that request capture explicitly accepts. These gaps can produce falsely verified candidates or make an entire supported PR class fail only at publication.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
3 verified findings remained after source verification (2 high, 1 medium) across 3 files. Details are attached to the affected lines below.

Affected areas: .github/scripts/pr_repair_worker/python_verify.py, .github/scripts/verify_pr_repair.py, .github/workflows/devflow-repair-publish.yml

Comment thread .github/scripts/pr_repair_worker/python_verify.py Outdated
Comment thread .github/scripts/verify_pr_repair.py Outdated
Comment thread .github/workflows/devflow-repair-publish.yml Outdated

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The security-sensitive cross-repository workflow depends on an external DevFlow pipeline that is unavailable for end-to-end review.

Review effort: Balanced
Findings: None

Resolved since last review (5)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 2

Result: No findings
Scope: 1 net-new commit(s): 5a57d8501062
Model: gpt-5.6-sol-fast

Overview

This increment moves repair execution out of the repository and leaves a compact gateway that freezes the PR and command, verifies the snapshot digest and event identity, authorizes the frozen requester, and dispatches a pinned DevFlow controller revision. Its strongest guardrails are the trusted helper checkout, App-only membership token, fail-closed team check, bounded snapshot, and SHA-pinned actions. The reviewers identified concurrency and retry limitations, but the concrete local forms predate this review range, while the external ordering concern lacks evidence of a violated DevFlow contract.

Reviewed the supplied incremental change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@moonbox3
Evan Mattson (moonbox3) added this pull request to the merge queue Sep 22, 2026
Merged via the queue into microsoft:main with commit a8acb4e Sep 22, 2026
29 checks passed
@moonbox3
Evan Mattson (moonbox3) deleted the devflow-fix-ci branch September 22, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants