Protect setup files and avoid publisher trust prompts - #103
Draft
AmirMS (AmelBawa-msft) wants to merge 2 commits into
Draft
AmirMS (AmelBawa-msft) wants to merge 2 commits into
AmirMS (AmelBawa-msft) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Signature verification currently fails on supported PowerShell versions before 7.4, and existing install roots may prevent reboot resume.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Secures Calm OS setup files and replaces AllSigned launches with verified, prompt-free RemoteSigned execution.
Changes:
- Adds signature and ACL validation.
- Installs under protected
%ProgramData%\CalmOS. - Updates bootstrap, relaunch behavior, and documentation.
File summaries
| File | Description |
|---|---|
src/windows-dev-config/steps/_security.ps1 |
Adds signature and permission checks. |
src/windows-dev-config/steps/_elevation.ps1 |
Uses RemoteSigned for relaunches. |
src/windows-dev-config/dev-config.ps1 |
Validates files before loading helpers. |
src/windows-dev-config/bootstrap.ps1 |
Adds protected download, installation, and elevation. |
src/windows-dev-config/README.md |
Documents the new security model. |
src/docs/development.md |
Updates contributor guidance. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Assert-DevConfigProtectedPath -Path $ancestor.FullName -Ancestor | ||
| } | ||
|
|
||
| if (-not (Test-Path -LiteralPath $Path)) { |
JohnMcPMS
reviewed
Sep 17, 2026
JohnMcPMS
left a comment
Member
There was a problem hiding this comment.
Given the lack of support for the memory-based signature check, I think the path is:
- First run creates directory under install root, copies all scripts there.
- Changes owner and ACLs to admin only write with everyone read/execute
- Verifies signature on the entry point script one more time
- Invokes the entry point script with signature validation elevated
- Elevated script revalidates signatures for all files
- Continue with actual work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.