Classify private identifiers in semantic tokens - #64349
Open
Jake Bailey (jakebailey) with Copilot wants to merge 2 commits into
Open
Jake Bailey (jakebailey) with Copilot wants to merge 2 commits into
Jake Bailey (jakebailey) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix omission of PrivateIdentifier nodes in semantic classifications
Classify private identifiers in semantic tokens
Sep 19, 2026
Jake Bailey (jakebailey)
marked this pull request as ready for review
September 19, 2026 15:13
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 19, 2026 15:14
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches existing classification behavior and is covered by an appropriate fourslash regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Adds semantic-token classification for ECMAScript private identifiers.
Changes:
- Routes private identifiers through symbol classification.
- Adds regression coverage for private fields and methods.
| File | Description |
|---|---|
tsc/internal/ls/semantictokens.go |
Includes private identifiers in semantic-token collection. |
tsc/internal/fourslash/tests/semanticModernClassificationPrivateIdentifiers_test.go |
Verifies declaration and reference classifications. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECMAScript private names are
PrivateIdentifiernodes, so the semantic-token collector omitted them while classifying ordinary identifiers. Consequently, private fields and methods fell back to TextMate highlighting.Changes
PrivateIdentifiernodes in the existing symbol-classification path.propertyand private methods asmethod.declarationmodifier to private member declarations.