Fix import type code fix comment duplication - #64289
Open
Noamaan Mulla (noamaanMulla-03) wants to merge 1 commit into
Open
Noamaan Mulla (noamaanMulla-03) wants to merge 1 commit into
Noamaan Mulla (noamaanMulla-03) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Noamaan Mulla (noamaanMulla-03)
September 15, 2026 21:57
View session
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes a regression where the import type quick fix duplicated comments.
Changes:
- Registers the code-fix provider.
- Inserts
typedirectly afterimport. - Adds comment-preservation regression coverage.
File summaries
| File | Description |
|---|---|
tsc/internal/ls/codeactions.go |
Registers the provider. |
tsc/internal/ls/codeactions_converttotypeonlyimport.go |
Implements the text-based fix. |
tsc/internal/fourslash/tests/codeFixConvertToTypeOnlyImportComments_test.go |
Tests comment preservation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64272
Description
Fixes a regression where the
Use 'import type'quick fix duplicated comments surrounding a sole named import declaration.The quick fix now inserts
typeimmediately after the existingimportkeyword instead of rebuilding and reprinting the declaration. This preserves leading, inline, and trailing comments exactly once.Tests
go test ./tsc/internal/ls/... -count=1go test ./tsc/internal/fourslash/tests -run '^TestCodeFixConvertToTypeOnlyImportPreservesComments$' -count=1