Directories dont check modified time when sending "change" event - #57938
Merged
Merged
Conversation
This was referenced Mar 25, 2024
Directories generate change event in multiple scenarios and should not filter events based on modified time Fixes #57792
Sheetal Nandi (sheetalkamat)
force-pushed
the
useFsEventsOnParentDirectory
branch
from
March 25, 2024 21:13
98bcd9d to
88c5588
Compare
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Branch (andrewbranch) and
Jake Bailey (jakebailey)
March 25, 2024 21:14
Jake Bailey (jakebailey)
approved these changes
Mar 25, 2024
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
Does this need a backport to 5.4?
Member
Author
|
Daniel Rosenwasser (@DanielRosenwasser) Ryan Cavanaugh (@RyanCavanaugh) do we want this for 5.4 ? If we need to port this, there will be test breaks unless we take #57936 |
Member
|
The cherry pick task will fix up the baselines, so that all would be handled (but we can still manually fix it) |
Contributor
|
Just to check - is this going to be backported to 5.4 or only 5.5? |
Member
|
I think it's worth considering. TypeScript Bot (@typescript-bot) cherry-pick this to release-5.4 |
Contributor
TypeScript Bot (typescript-bot)
pushed a commit
that referenced
this pull request
Mar 27, 2024
Contributor
|
Hey, Jake Bailey (@jakebailey)! I've created #57958 for you. |
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Mar 28, 2024
…e-5.4 (#57958) Co-authored-by: Sheetal Nandi <shkamat@microsoft.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Contributor
|
Apologies for the direct mention Jake Bailey (@jakebailey), but is a new 5.4 version still planned to go out at some point? |
Member
|
This was in 5.4.4 which came out last week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking whether to send event invoked with
fs.watchwe shouldnt do that for directory. Directory can sendchangeevent for multiple reasons and its not right to filter that out.a7a308d Adds the failing test. It modifies out vfs sending incorrect timestamps, incorrect events etc.
88c5588 actual fix
Fixes #57792