shared/netutils: Factor mp_hal_get_mac_ascii out of ports. - #19674
Open
pablogventura wants to merge 1 commit into
Open
pablogventura wants to merge 1 commit into
pablogventura wants to merge 1 commit into
Conversation
|
Code size report: |
projectgus
reviewed
Sep 3, 2026
projectgus
left a comment
Contributor
There was a problem hiding this comment.
The assert looks reasonable, but this looks like we should actually move this utility function somewhere else (maybe a new file in extmod/?) instead of maintaining five identical copies of it.
Move the identical helper from stm32/rp2/mimxrt/renesas-ra/alif into shared/netutils and assert the hex character slice stays within the 12-character MAC representation. Fixes micropython#19668. Signed-off-by: Pablo Ventura <pablogventura@gmail.com>
Contributor
Author
|
@projectgus Thanks for the review. Consolidated the five copies into |
pablogventura
force-pushed
the
ports-mac-ascii-bounds
branch
from
September 5, 2026 02:22
2c86a33 to
cbf4ccd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19674 +/- ##
==========================================
- Coverage 98.56% 98.55% -0.01%
==========================================
Files 182 182
Lines 23335 23335
Branches 5 5
==========================================
- Hits 22999 22998 -1
- Misses 335 336 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19668.
mp_hal_get_mac_asciiindexedmac[chr_off >> 1]without checking that the requested hex slice stays within the 12-character MAC representation, sochr_off == 12readmac[6].The same helper was duplicated in stm32, rp2, mimxrt, renesas-ra, and alif. Move it to
shared/netutils/get_mac_ascii.cand addassert(chr_off <= 12 && chr_len <= 12 - chr_off)in that single copy. In-tree callers use(8, 4)and are unchanged.Testing
get_mac_ascii.cinto each port's shared/netutils sourcesTrade-offs and Alternatives
assert(not a runtime clamp): zero cost in typical release builds withNDEBUG, matches other HAL programmer-error checks. Invalid callers still trap in assert-enabled builds.shared/netutilsrather than a newextmod/file: this is a portable C HAL helper (no Python module), and these ports already buildshared/netutils.No unix
.textdelta (port HAL / shared helper only).Generative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above.