Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
On macOS, using the CoreText framework when AppKit is not loaded into memory can result in exceptions if AppKit is later used.
Consider the following example:
example.py
If
LOAD_APPKIT_FIRSTisTrue, we will load AppKit before our call toCTFontCollectionCreateFromAvailableFonts(). This sets up bridging and allows later calls in AppKit that assume aNSFontobject to instead operate on aCTFontobject.If
LOAD_APPKIT_FIRSTisFalse, AppKit will later try to send an Obj-C message to aCTFontobject and we will get an exception. I'm not 100% sure of the exact details here. I could find out, but it would require a few hours of decompiling AppKit code.I don't want to always pull in AppKit when
_c_internal_utilsis loaded. Instead, this PR only loads it inmpl_get_available_fonts(), which should only be called when rebuilding the font cache.AI Disclosure
PR quality check