Conversation
_draw_text_glyphs_and_boxes runs once per glyph of every string drawn.
Contributor
|
I think this might be covered already in #32120, which needs a second review? (I'm on top of a mountain in the wilderness and can't check!) |
Contributor
Author
|
Indeed! I missed that when I was searching, thanks for pointing it out. I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
_draw_text_glyphs_and_boxesruns once per glyph of every string drawn. I get about 1.1-1.2x speedup locally with this.AI Disclosure
AI found this and implemented the initial updates, I reviewed and cleaned up all code.
PR quality check