Fix quad mesh cursor data - #22907
Merged
Merged
Conversation
QuLogic
reviewed
Apr 27, 2022
Member
|
I took the liberty of editing your post to point out the issue number. In this way, Github links this PR and the issue and the issue will be automatically closed when this is merged. |
oscargus
approved these changes
Apr 29, 2022
Contributor
Author
|
@oscargus perfect, thanks! I don't have the rights to merge anything so this needs to be done by one of your devs as well! |
QuLogic
approved these changes
Apr 30, 2022
Member
|
meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 30, 2022
Member
|
Thanks @raphaelquast! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
QuLogic
added a commit
that referenced
this pull request
Apr 30, 2022
…907-on-v3.5.x Backport PR #22907 on branch v3.5.x (Fix quad mesh cursor data)
Contributor
|
I don't think this was quite right because Hover the cursor over the figure in this example: import matplotlib.pyplot as plt
import numpy as np
n = 4
x = np.arange(n)
X = x[:, None] * x[None, :]
fig, ax = plt.subplots()
mesh = ax.pcolormesh(X)
mesh.set_mouseover(True)
plt.show() |
Contributor
Author
|
@greglucas sorry... indeed that's not the desired behavior! I opened a new pull request to fix this. (#22957)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes: #22908
This is just a very minor bug I noticed...
When using a
QuadMeshwithout setting an array, theget_cursor_datafunction throws an error because it does not check if an array has been set.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).