Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JSpecify type-use nullness on array components and collection elements was not preserved when MapStruct resolved container mapping methods. This caused generated element mappings to invoke a non-null mapping method with a nullable array or collection element.
Changes
Generated code impact
Generated array and iterable mappings now guard nullable source elements before invoking an element mapping method and retain null elements when the target element type permits null. Top-level container nullness and non-JSpecify nullability behavior remain unchanged.
Tests
Tested on Java 25; the processor continues to compile with Java 8 source/target compatibility and uses the repository's Java 21 test baseline.
Fixes #4035