Env variables cleanup - #641
Merged
Merged
Conversation
✅ Deploy Preview for lowcoder-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ludomikula
force-pushed
the
env-variables-cleanup
branch
from
January 16, 2024 16:35
2e38f76 to
27ca2d4
Compare
FalkWolsky
approved these changes
Jan 16, 2024
FalkWolsky
left a comment
Contributor
There was a problem hiding this comment.
Impressive. What a wonderful contribution to develop step by step more clean structure of the project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Docker image(s) and helm variables cleanup and rename. To make more sense in the environment variables, we renamed and unified them. As such this is a breaking change for your current docker-compose files!
Here is the table of all old variables names mapped to the new ones:
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
xin the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
xin the boxes that apply.Further comments
This change breaks your existing docker-compose and helm values.yaml because the environment variables were renamed!