Skip to content

fix(reward-memory): reconcile live configuration and guide requalification - #4866

Open
huangruiteng wants to merge 2 commits into
mainfrom
codex/reward-memory-requalification-20260921
Open

huangruiteng wants to merge 2 commits into
mainfrom
codex/reward-memory-requalification-20260921

Conversation

@huangruiteng

@huangruiteng huangruiteng commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Changing a private Reward Memory configuration invalidates its enablement receipt, but the settings catalog could still show cached verification and the recall CLI called the failure disabled. Operators and agents received no actionable recovery plan.

This change keeps the drift guard, makes the catalog reuse runtime admission validation, and separates desired automation/historical verification from effective availability. Stale or unverified bindings expose a shared configure-goal preview/apply/verify plan that retains the existing configuration pointer and complete Agent allowlist. Each command template requires an explicit invocation-registry binding, so copying it cannot silently fall back to the default registry. Applying still performs provider write/exact-readback qualification and registry synchronization; it does not automatically trust a changed configuration.

User entry points: CLI recall, quota/managed-Turn projection, status/Markdown, and the existing frontend capability configuration summary share these results. The existing editor already supports preview/reapply with the retained pointer and Agent list. No new frontend controls or bundle changes are needed: the existing summary renders the updated current projection. Lark continues to consume shared status; no new chat state owner is introduced.

Validation:

  • 89 focused tests passed across Reward Memory, turn recall, outcome lifecycle, capability configuration UI contract and chat configuration API.
  • Ruff and git diff --check passed.
  • Negative cases cover drift, unverified/disabled bindings, missing configuration, and mismatched Goal/Agent/provider/isolation receipts. Reading recovery guidance performs no provider writes or registry mutation.
  • Separately qualified local recovery through the existing owner, followed by one reviewed experience write, exact readback and an independent business recall. Private configuration, memories and receipts are excluded from this PR.
  • No browser visual acceptance was run for the unchanged frontend renderer; no claim of improved decision quality is made from successful storage alone.

中文:私有配置变化后旧启用回执失效,但设置页仍可能误报已验证,召回 CLI 又将故障统一标为 disabled。本修改保留漂移保护,设置页复用运行时准入校验,区分期望配置、历史回执与当前可用性;失配时提供沿用原指针及完整 Agent 名单的共享 owner 恢复计划。CLI、managed Turn、状态与现有设置页共用投影,不引入新配置权威。89 项测试通过;本机已完成现有 owner 恢复、真实经验写入、精确读回和独立业务召回,私有材料不进入仓库。代码提交审阅,尚未宣称已部署。

Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant