Format error on exception handling - #34
Merged
frenchfrywpepper merged 1 commit intoFeb 22, 2018
Merged
Conversation
* traceback.format_exc first arg is limit, not an exception instance * format args should be splatted
frenchfrywpepper
approved these changes
Feb 22, 2018
frenchfrywpepper
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix!
katiabazzi
approved these changes
Feb 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions during worker flush were being swallowed and turned into IndexErrors on the format tuple in
_fine. This just cleans up a couple things so the exception is surfacedargsfor format should be splatted when passedtraceback.format_excfirst arg islimit, not an exception instance