Rework symbols for proper TLS support - #297
Draft
MrIndeciso wants to merge 5 commits into
Draft
MrIndeciso wants to merge 5 commits into
MrIndeciso wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces comprehensive TLS (Thread-Local Storage) symbol support and reworks the symbol backend to properly handle various ELF symbol types, bindings, and visibility. It builds upon PR #282 which introduced the ELF API. The PR description notes this is "currently AI-generated, needs a lot of rework and refactoring."
Changes:
- Added TLS symbol resolution with TLSResolver class and comprehensive test suite
- Enhanced Symbol dataclass with new fields for type, binding, visibility, TLS metadata, demangling, versioning, PLT/GOT detection
- Implemented ELF API for parsing sections, dynamic sections, program headers, GNU properties, and Linux runtime mitigations
- Added native C++ infrastructure for parsing ELF structures and improved symbol parsing with proper type/binding/visibility detection
Reviewed changes
Copilot reviewed 61 out of 100 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| libdebug/data/symbol.py | Extended Symbol with TLS, type, binding, visibility, versioning |
| libdebug/data/symbol_list.py | Added filtering by type/binding, TLS property accessors, demangled name search |
| libdebug/data/symbol_types.py | New enums for SymbolType, SymbolBinding, SymbolVisibility |
| libdebug/symbols/tls_resolver.py | New TLSResolver for resolving TLS addresses across threads |
| libdebug/data/elf/*.py | Complete ELF API with sections, dynamic sections, program headers, GNU properties, mitigations |
| libdebug/native/symbols/* | Enhanced native symbol parsing with type/binding/TLS detection |
| libdebug/native/elf/* | Native ELF parsing infrastructure for sections/segments/properties |
| libdebug/debugger/*.py | Integration of ELF API and libraries parsing into debugger |
| test/srcs/*.c | Comprehensive test binaries for TLS, symbols, sections, mitigations |
| test/scripts/*.py | Test suites for TLS resolution, symbol backend, ELF API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 49 out of 55 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MrIndeciso
added a commit
that referenced
this pull request
Feb 2, 2026
MrIndeciso
force-pushed
the
better-symbols
branch
from
February 2, 2026 18:24
1fbdefa to
70fde42
Compare
MrIndeciso
force-pushed
the
better-symbols
branch
from
February 2, 2026 21:19
70fde42 to
d8e0ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: built on top of #282
Note: currently AI-generated, needs a lot of rework and refactoring