Multiple bps - #175
Open
io-no wants to merge 13 commits into
Open
Multiple bps#175io-no wants to merge 13 commits into
io-no wants to merge 13 commits into
Conversation
Frank01001
reviewed
Mar 21, 2025
| @property | ||
| def hit_count(self: BreakpointList) -> int: | ||
| """Returns the sum of the hit counts of all the breakpoints inside the BreakpointList.""" | ||
| return sum(bp.hit_count for bp in self) |
Member
There was a problem hiding this comment.
This would multiply the hit count for the number of superimposed breakpoints... Is this really what we want?
Frank01001
reviewed
Mar 21, 2025
| return [bp.callback for bp in self] | ||
|
|
||
| @property | ||
| def enabled(self: BreakpointList) -> bool: |
Member
There was a problem hiding this comment.
Do we want to set enabled on the list to enable all or disable all breakpoints at that address? If not, I would rename this property to avoid confusion (because of the symmetry with the property of the breakpoint object itself).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for multiple breakpoints at the same location. Below are the design choices I made during development to ensure alignment:
Breakpoint Dictionary Enhancement:
BreakpointListtype similar to other custom types inlibdebug. This supports thefiltermethod, allowing filtering by any breakpoint attribute.Hardware Breakpoints on Specific Threads:
libdebug, it aligns with external behavior and allows the saving of precious hardware breakpoints.Process-Scoped Software Breakpoints:
libdebug.Managing Multiple Hardware Breakpoints:
Coexistence of Software and Hardware Breakpoints: