Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a lifecycle bug where Langfuse traces stopped exporting after OpenCode disposed and re-created the plugin instance in the same process.
OpenCode can re-create plugin instances when the effective runtime configuration changes, such as after a model or plugin configuration update. The plugin's dispose path shut down the process-wide OpenTelemetry tracer provider. Since that provider cannot be registered again in the same process, spans created after the plugin was re-created were silently dropped.
OpenCode 0.5.0 also requires the re-created plugin instance to reuse the existing Langfuse client. Otherwise, spans can be created through the process-wide provider while
forceFlushoperates on a different provider.The plugin now:
Verification
pnpm installpnpm run formatpnpm run format:checkpnpm run buildpnpm run lintpnpm run knippnpm run test:integration