Conversation
When running without native support, we cannot do any of the pid- based waits. However in many instances it may be more damaging to raise a hard error for the unimplemented logic rather than just warning and doing nothing. This commit changes the logic of these methods to report not implemented and warn rather than failing outright. The methods are also marked as not implemented in case code checks this (though I have no such examples).
Member
Author
|
The commit in this PR was originally created in service of #6649, due to the tests attempting to use waitpid, but it turned out the tests had several other places they needed real native IO support. I push this as a PR here to discuss whether this would be better behavior for these methods when we cannot implement them. |
headius
force-pushed
the
kinder_gentler_waitpid
branch
from
April 6, 2021 20:07
559777b to
36fcb1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running without native support, we cannot do any of the pid-
based waits. However in many instances it may be more damaging to
raise a hard error for the unimplemented logic rather than just
warning and doing nothing. This commit changes the logic of these
methods to report not implemented and warn rather than failing
outright. The methods are also marked as not implemented in case
code checks this (though I have no such examples).