Conversation
Fixes ipython#14516 Keep escaped POSIX CLI paths in one token and classify directories using filesystem paths before display escaping. Cover completion and traversal through the prompt-toolkit adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14516.
Complete directories containing spaces with a trailing
/, then allow completion to continue into their children. Directory detection now uses the filesystem path before display escaping, and POSIX CLI argument splitting keeps escaped spaces in the same path token.Adds a regression test through the prompt-toolkit completion adapter for selecting a spaced directory and continuing into a spaced child directory, with ordinary-directory and file controls. The reproduction uses Linux/POSIX; the original macOS UI and Windows have not been exercised.
🤖🤖 AI-assisted with Codex (GPT-6 Astra and GPT-5.6 Luna).
Baseline and candidate trajectory