Skip to content

Use current buffer for attribute completions #15244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MUFFANUJ wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −11
Open

Use current buffer for attribute completions #15244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions IPython/core/completer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,19 +1278,20 @@ def _attr_matches(
except tokenize.TokenError:
pass

obj = self._evaluate_expr(expr)
if obj is not_found:
if context:
# try to evaluate on full buffer
previous_lines = "\n".join(
context.full_text.split("\n")[: context.cursor_line]
obj = not_found
if context:
# try to evaluate on full buffer
previous_lines = "\n".join(
context.full_text.split("\n")[: context.cursor_line]
)
if previous_lines:
all_code_lines_before_cursor = (
self._extract_code(previous_lines) + "\n" + expr
)
if previous_lines:
all_code_lines_before_cursor = (
self._extract_code(previous_lines) + "\n" + expr
)
obj = self._evaluate_expr(all_code_lines_before_cursor)
obj = self._evaluate_expr(all_code_lines_before_cursor)

if obj is not_found:
obj = self._evaluate_expr(expr)
if obj is not_found:
return [], ""

Expand Down
16 changes: 16 additions & 0 deletions tests/test_completer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,6 +2575,22 @@ def test_undefined_variables(use_jedi, evaluation, code, insert_text):
assert len(match) == 1, message_on_fail


def test_attribute_completion_uses_current_buffer_redefinition():
code = "\n".join(["a = []", "a."])
ip = get_ipython()
ip.user_ns["a"] = 1

try:
with provisionalcompleter(), jedi_status(False), evaluation_policy("limited"):
completions = list(ip.Completer.completions(text=code, offset=len(code)))
finally:
del ip.user_ns["a"]

completion_texts = {completion.text.lstrip(".") for completion in completions}
assert "append" in completion_texts
assert "as_integer_ratio" not in completion_texts


@pytest.mark.parametrize(
"code,insert_text",
[
Expand Down
Loading