Remove v1 version of unicode and latex matchers - #14728
Merged
Merged
Conversation
Goal is to eventually remove all _convert_matcher_v1_result_to_v2 from this file
Member
|
Awesome ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to eventually remove all
_convert_matcher_v1_result_to_v2from this fileContext: I want to fix #14516. The bug is narrowed down to
completer.py@Carreau advised me to start removing v1 matchers first, so it's easier to work on the completer.
I'm starting with 2 small changes and will do the others in future MRs.