Skip to content

fix: adds enriched attribute for API Trace error count - #172

Merged
JBAhire merged 8 commits into
mainfrom
api-error-count
Apr 15, 2021
Merged

fix: adds enriched attribute for API Trace error count#172
JBAhire merged 8 commits into
mainfrom
api-error-count

Conversation

@JBAhire

@JBAhire JBAhire commented Apr 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Description

@codecov

codecov Bot commented Apr 15, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #172 (7501b02) into main (81e65d8) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #172      +/-   ##
============================================
- Coverage     78.23%   78.23%   -0.01%     
  Complexity     1021     1021              
============================================
  Files            95       95              
  Lines          4218     4231      +13     
  Branches        396      397       +1     
============================================
+ Hits           3300     3310      +10     
  Misses          737      737              
- Partials        181      184       +3
Flag Coverage Δ Complexity Δ
unit 78.23% <88.88%> (-0.01%) 1021.00 <13.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../enrichedspan/constants/EnrichedSpanConstants.java 50.00% <ø> (ø) 2.00 <0.00> (ø)
...ichment/enrichers/ErrorsAndExceptionsEnricher.java 86.66% <86.66%> (-2.09%) 19.00 <13.00> (ø)
...ewgenerator/generators/SpanEventViewGenerator.java 92.36% <100.00%> (+0.17%) 31.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e65d8...7501b02. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@JBAhire
JBAhire marked this pull request as ready for review April 15, 2021 09:10
@JBAhire
JBAhire requested review from a team, findingrish, kotharironak and skjindal93 April 15, 2021 09:10
@JBAhire JBAhire mentioned this pull request Apr 15, 2021
Merged
3 tasks
skjindal93
skjindal93 reviewed Apr 15, 2021
View reviewed changes
Comment thread ...c/main/java/org/hypertrace/traceenricher/enrichedspan/constants/utils/EnrichedSpanUtils.java Outdated
Comment thread ...main/java/org/hypertrace/traceenricher/enrichment/enrichers/ErrorsAndExceptionsEnricher.java Outdated
Comment thread ...main/java/org/hypertrace/traceenricher/enrichment/enrichers/ErrorsAndExceptionsEnricher.java Outdated
Comment thread ...main/java/org/hypertrace/traceenricher/enrichment/enrichers/ErrorsAndExceptionsEnricher.java Outdated
Comment thread ...main/java/org/hypertrace/traceenricher/enrichment/enrichers/ErrorsAndExceptionsEnricher.java Outdated
Comment thread .../java/org/hypertrace/traceenricher/enrichment/enrichers/ErrorsAndExceptionsEnricherTest.java Outdated
Comment thread hypertrace-view-generator/hypertrace-view-generator-api/src/main/avro/SpanEventView.avdl Outdated
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@JBAhire
JBAhire requested a review from skjindal93 April 15, 2021 12:27
@github-actions

This comment has been minimized.

Sign in to view
@JBAhire
JBAhire merged commit 056a476 into main Apr 15, 2021
@JBAhire
JBAhire deleted the api-error-count branch April 15, 2021 12:31
@github-actions

github-actions Bot commented Apr 15, 2021

Copy link
Copy Markdown

Unit Test Results

  57 files  ±0    57 suites  ±0   53s ⏱️ +2s
299 tests +1  299 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 056a476. ± Comparison against base commit 81e65d8.

@JBAhire JBAhire mentioned this pull request Apr 15, 2021
Merged
3 tasks
@JBAhire JBAhire mentioned this pull request Apr 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjindal93 skjindal93 skjindal93 approved these changes
@kotharironak kotharironak Awaiting requested review from kotharironak
@findingrish findingrish Awaiting requested review from findingrish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JBAhire @skjindal93