feat: add support for optional tyoe usage in schema - #65
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
============================================
+ Coverage 59.50% 59.53% +0.03%
Complexity 233 233
============================================
Files 79 79
Lines 1210 1211 +1
Branches 35 35
============================================
+ Hits 720 721 +1
Misses 462 462
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
GurtejSohi
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throughout the gql modules we avoid using null and instead use safer constructs like Optional and Maybe to handle presence. In the schema, nullability is handled through annotations, but within the code we would like to keep the objects consistent with the rest of the code. graphql-java-annotations already supports this, so here we bring our deserializer in line.
Testing
Manually verified with an optional type