feat: Add adding alerting to k8s - #270
Merged
Merged
Conversation
added 2 commits
July 28, 2021 17:08
JBAhire
reviewed
Jul 28, 2021
JBAhire
left a comment
Member
There was a problem hiding this comment.
LGTM, once these small comments are addressed. :)
| - name: hypertrace-alert-engine | ||
| repository: "https://storage.googleapis.com/hypertrace-helm-charts" | ||
| version: 0.1.4 | ||
| condition: alerting.enabled |
Member
There was a problem hiding this comment.
should we disable it by default?
Member
There was a problem hiding this comment.
The reason being, there won't be any slack URL and all so this will be failing anyways.
| }, | ||
| "valueOperator": "VALUE_OPERATOR_EQ", | ||
| "rhsExpression": { | ||
| "stringValue": "customer" |
Member
There was a problem hiding this comment.
This seems specifically tied to hotrod. Can we make it more abstract?
Author
There was a problem hiding this comment.
this is just some starter stuff, can be generalised later
JBAhire
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add alerting service to k8s