Skip to content

Use Spotless for code formatting - #358

Merged
bestbeforetoday merged 1 commit into
hyperledger:mainfrom
bestbeforetoday:spotless
Oct 25, 2024
Merged

bestbeforetoday merged 1 commit into
hyperledger:mainfrom
bestbeforetoday:spotless

Conversation

@bestbeforetoday

@bestbeforetoday bestbeforetoday commented Oct 22, 2024

Copy link
Copy Markdown
Member

Spotless is widely used opinionated Java code formatter. It will also fix incorrect formatting using ./gradlew spotlessApply, avoiding the need for contributors to manually correct any formatting violations flagged by Checkstyle. Formatting rules defined by Checkstyle that would otherwise cause conflicts with the formatting applied by Spotless are removed.

The only non-formatting changes are to CONTRIBUTING.md, build.gradle and ci/checkstyle/checkstyle.xml.

This change also updates the Gradle version to 8.10.2.

@bestbeforetoday
bestbeforetoday force-pushed the spotless branch 3 times, most recently from 306fbde to ff27a0b Compare October 22, 2024 19:15
Spotless is widely used opinionated Java code formatter. It will also
fix incorrect formatting using `./gradlew spotlessApply`, avoiding the
need for contributors to manually correct any formatting violations
flagged by Checkstyle. Formatting rules defined by Checkstyle that would
otherwise cause conflicts with the formatting applied by Spotless are
removed.

This change also updates the Gradle version to 8.10.2.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@sonarqubecloud

Copy link
Copy Markdown

@bestbeforetoday
bestbeforetoday marked this pull request as ready for review October 23, 2024 17:17
@bestbeforetoday
bestbeforetoday requested a review from a team as a code owner October 23, 2024 17:17
@bestbeforetoday
bestbeforetoday enabled auto-merge (squash) October 23, 2024 17:19

@denyeart denyeart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bestbeforetoday
bestbeforetoday merged commit 4895f92 into hyperledger:main Oct 25, 2024
@bestbeforetoday
bestbeforetoday deleted the spotless branch October 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants