Integration test overhaul - #277
Conversation
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
23e6c90 to
e0fa388
Compare
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
e0fa388 to
bf5ac7a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jt-nti
left a comment
There was a problem hiding this comment.
A couple of minor comments and some concern about ccutil but definitely looks like an improvement, and hopefully admin apis may help further in the future
| * | ||
| * | ||
| */ | ||
| public class Bash extends Command { |
There was a problem hiding this comment.
I'm slightly confused whether this is a generic bash command, as the class name would suggest, or specifically a peer command
| Command(List<String> cmd, Map<String,String> additionalEnv){ | ||
| this.cmd = cmd; | ||
| this.env = new HashMap<>(); | ||
| // this.env = new HashMap(System.getenv()); |
There was a problem hiding this comment.
Did you mean to leave this commented out? Will not having the system env cause any problems?
| Command(List<String> cmd) { | ||
| this.cmd = cmd; | ||
| this.env = new HashMap(); | ||
| // this.env = new HashMap(System.getenv()); |
There was a problem hiding this comment.
Did you mean to leave this commented out? Will not having the system env cause any problems?
|
@mergify backport release-2.5 |
✅ Backports have been createdDetails
|
PR to resolve issues with the integration tests failing; slightly larger PR than ideal for the scale of the fix. However the original infrastructure used for the integration tests was a derivative of the (very) old byfn test network - and it was using old lifecycle and not updated in any recent time.
Therefore it seemed a manageable risk to remove it entirely and go with the modern solution of pulling in the single docker image of Microfab to use to spin up a real fabric network for testing.
Changes made: