[Snyk] Security upgrade @angular/cli from 0.0.0-use.local to 1.0.0 - #22
hashim21223445 wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
|
Review changes with |
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Summary of ChangesHello @hashim21223445, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security upgrade for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to address a security vulnerability by upgrading @angular/cli. However, the proposed change is incorrect for this project's monorepo structure. It replaces a placeholder version ("0.0.0-PLACEHOLDER") with a hardcoded and very outdated version ("1.0.0"). This will break the project's release process and cause the @angular/create package to depend on an ancient version of the CLI. The change should be rejected, and the placeholder version should be restored.
| "bin": "./src/index.js", | ||
| "dependencies": { | ||
| "@angular/cli": "0.0.0-PLACEHOLDER" | ||
| "@angular/cli": "1.0.0" |
There was a problem hiding this comment.
This change incorrectly replaces the placeholder version "0.0.0-PLACEHOLDER" with a hardcoded, outdated version "1.0.0".
In this monorepo, placeholder versions like "0.0.0-PLACEHOLDER" are used for local development and are automatically replaced with the correct package version during the release process.
Hardcoding @angular/cli to version "1.0.0" will break this versioning scheme. When @angular/create is published, it will incorrectly depend on this very old version of @angular/cli instead of the version corresponding to the current release train (e.g., v18+). This would cause users of npx @angular/create to scaffold outdated Angular projects.
This automated change from Snyk appears to be based on a misinterpretation of the project's versioning strategy. The change should be reverted to keep the placeholder.
| "@angular/cli": "1.0.0" | |
| "@angular/cli": "0.0.0-PLACEHOLDER" |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/angular/create/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.