Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing an untrusted query with an oversized braced unicode escape throws an internal exception instead of a syntax error:
the grammar allows
{ Hex+ }with any number of digits (EscapedUnicode : Hex Hex Hex Hex | '{' Hex+ '}'), so a value that overflows int reaches Integer.parseInt in parseAndWriteUnicode. the leading escape path catches the NumberFormatException but builds the error with InvalidUnicode.invalidHexString, a key that is missing from every Parsing bundle, so it fails with an AssertException; the trailing-surrogate path (line 53) has no catch at all and leaks the raw NumberFormatException. both should be a normal InvalidSyntaxException.wrap the trailing parse the same way the leading one is wrapped and add the missing message key to the en/de/nl bundles.