fix: clean randomized contraction checkpoints on failure - #895
Merged
SemyonSinchenko merged 1 commit intoAug 31, 2026
Conversation
SauronShepherd
force-pushed
the
codex/randomized-contraction-checkpoint-cleanup
branch
2 times, most recently
from
August 30, 2026 01:03
43fd7fa to
01d14a4
Compare
SauronShepherd
force-pushed
the
codex/randomized-contraction-checkpoint-cleanup
branch
from
August 30, 2026 01:27
01d14a4 to
a4cc58d
Compare
SemyonSinchenko
approved these changes
Aug 31, 2026
SemyonSinchenko
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure that RandomizedContraction checkpoint directories are cleaned up on both successful and failed executions.
A scoped cleanup routine is now called from the normal completion path and from finally. Cleanup failures are logged without masking the original algorithm failure.
A regression test forces a failure after intermediate parquet materialization and verifies that no randomized-contraction-* directory remains.
Why are the changes needed?
If an intermediate Spark or filesystem operation fails, the current implementation can leave temporary checkpoint data behind. Repeated executions can therefore leak storage, especially when using remote object stores.
This addresses #894.
Validation
The change does not modify public APIs.