Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

test: add env-tests-logging submodule - #539

Merged
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
envTestsSubmodule
May 24, 2021
Merged

gcf-merge-on-green[bot] merged 1 commit into
masterfrom
envTestsSubmodule

Conversation

@simonz130

Copy link
Copy Markdown

Adding environment tests repo as a submodule.

This PR is part of onboarding to environment tests framework for java-logging repo.

@simonz130 simonz130 added type: process A process-related concern. May include testing, release, or the like. api: logging Issues related to the googleapis/java-logging API. labels May 24, 2021
@simonz130
simonz130 requested a review from daniel-sanche May 24, 2021 19:11
@simonz130 simonz130 self-assigned this May 24, 2021
@simonz130
simonz130 requested review from a team May 24, 2021 19:11
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2021

@daniel-sanche daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would probably name the folder something like "environment-tests" instead of "env-tests-logging". But LGTM as is

@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 7ffd85f into master May 24, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the envTestsSubmodule branch May 24, 2021 20:04
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants