Firestore: fix delete conformance - #6559

Merged

tseaver merged 36 commits into

googleapis:masterfrom

tseaver:6533-firestore-fix-delete-conformance

Nov 27, 2018

Commits on Nov 22, 2018

Make sentinels more self-describing.
tseaver
committed
e853704
Factor out '_make_field_path' helper for tests.
tseaver
committed
1123bb4
Add '_helpers.extract_fields'.
tseaver
committed
7e2cc31
Add '_helpers.set_field_value'.
tseaver
committed
d31f7a5
Add '_helpers.ExtractDocumentTransforms' class.
tseaver
committed
53ca9f0
Refactor '_helpers.pbs_for_create':
tseaver
committed
751b47f
Refactor '_helpers.pbs_for_set_no_merge':
tseaver
committed
93b5ac9
Add 'ExtractDocumentTransforms.get_update_pb'.
tseaver
committed
1ca8559
Add 'ExtractDocumentTransforms.get_transform_pb'.
tseaver
committed
18ff9a0
Add 'ExtractDocumentTransforms.has_transforms'.
tseaver
committed
2c5ff6d
Test 'EDT.has_tranforms' in ctor tests.
tseaver
committed
0b132e2
Rename local: 'create_empty' -> 'merge_empty' for clarity.
tseaver
committed
275a807
Add 'get_field_value' helper.
tseaver
committed
45893ce
Add 'ExtractDocumentTransforms.transform_paths' method.
tseaver
committed
3030630
Add 'ExtractDocumentTransforms.apply_merge' method.
tseaver
committed
a3345bf
Refactor '_helpers.pbs_for_set_with_merge' to use 'ExtractDocumentTransforms'.
tseaver
committed
fdb8f20
Remove helpers no longer used by 'pbs_for_set_with_merge'.
tseaver
committed
5b04b90
Move '{Write,LastUpdate,Exists}Option' from 'client' to '_helpers'.
tseaver
committed
77e7aeb
Add 'expand_dots' argument to 'extract_fields' helper.
tseaver
committed
258f0f5
Add 'expand_dots' argument to 'ExtractDocumentTransforms' ctor.
tseaver
committed
87bdcc6
In 'extract_fields', do string parsing always when 'expand_dots' is True.
tseaver
committed
932b976
Add 'FieldPath.lineage' method.
tseaver
committed
bec5c29
Split only top-level keys on dots in 'extract_fields'.
tseaver
committed
c3daebd
Rename 'ExtractDocumentTransforms' -> 'DocumentExtractor'.
tseaver
committed
cc279dc
Factor out merge-specific behavior into a separate extractor class.
tseaver
committed
f23dc2b
Remove 'expand_dots' attr/argument from extractors.
tseaver
committed
7698129
Initial cut at 'DocumentExtractorForUpdate'.
tseaver
committed
573a108
Flesh out 'DocumentExtractorForUpdate'.
tseaver
committed
7992d17
Remove obslete helper: 'get_transform_pb'.
tseaver
committed
01502d0
Remove obslete helper: 'canonicalize_field_paths'.
tseaver
committed
3f0171c
Remove obslete helper: 'process_server_timestamp'.
tseaver
committed
b39867b
Remove obslete helper: 'filter_document_data_by_field_paths'.
tseaver
committed
e304470
Remove obslete helper: 'extract_field_paths'.
tseaver
committed
77c6522
Remove obslete helper: 'FieldPathHelper'.
tseaver
committed
b95bb36
Enable 'set-del' conformance tests, and fix.
tseaver
committed
a076abb
Enable 'update-del' conformance tests, and fix.
tseaver
committed
27ed61c

Navigation Menu

Firestore: fix delete conformance - #6559

Firestore: fix delete conformance#6559
tseaver merged 36 commits into
googleapis:masterfrom
tseaver:6533-firestore-fix-delete-conformance

Commits on Nov 22, 2018

Make sentinels more self-describing.

Factor out '_make_field_path' helper for tests.

Add '_helpers.extract_fields'.

Add '_helpers.set_field_value'.

Add '_helpers.ExtractDocumentTransforms' class.

Refactor '_helpers.pbs_for_create':

Refactor '_helpers.pbs_for_set_no_merge':

Add 'ExtractDocumentTransforms.get_update_pb'.

Add 'ExtractDocumentTransforms.get_transform_pb'.

Add 'ExtractDocumentTransforms.has_transforms'.

Test 'EDT.has_tranforms' in ctor tests.

Rename local: 'create_empty' -> 'merge_empty' for clarity.

Add 'get_field_value' helper.

Add 'ExtractDocumentTransforms.transform_paths' method.

Add 'ExtractDocumentTransforms.apply_merge' method.

Refactor '_helpers.pbs_for_set_with_merge' to use 'ExtractDocumentTransforms'.

Remove helpers no longer used by 'pbs_for_set_with_merge'.

Move '{Write,LastUpdate,Exists}Option' from 'client' to '_helpers'.

Add 'expand_dots' argument to 'extract_fields' helper.

Add 'expand_dots' argument to 'ExtractDocumentTransforms' ctor.

In 'extract_fields', do string parsing always when 'expand_dots' is True.

Add 'FieldPath.lineage' method.

Split only top-level keys on dots in 'extract_fields'.

Rename 'ExtractDocumentTransforms' -> 'DocumentExtractor'.

Factor out merge-specific behavior into a separate extractor class.

Remove 'expand_dots' attr/argument from extractors.

Initial cut at 'DocumentExtractorForUpdate'.

Flesh out 'DocumentExtractorForUpdate'.

Remove obslete helper: 'get_transform_pb'.

Remove obslete helper: 'canonicalize_field_paths'.

Remove obslete helper: 'process_server_timestamp'.

Remove obslete helper: 'filter_document_data_by_field_paths'.

Remove obslete helper: 'extract_field_paths'.

Remove obslete helper: 'FieldPathHelper'.

Enable 'set-del' conformance tests, and fix.

Enable 'update-del' conformance tests, and fix.