test(bigquery-jdbc): make picosecond ITs timezone independent and disable on TPC - #14435
Open
keshavdandeva wants to merge 4 commits into
Open
keshavdandeva wants to merge 4 commits into
keshavdandeva wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ITJdbcTimestampPicosTest class by introducing a helper method, atJvmZone, to convert and format UTC timestamp literals into the JVM's default time zone, which fixes zone-dependent assertion failures. Additionally, the test class is tagged with @tag("disable_tpc"). The review feedback suggests optimizing the helper method by defining the DateTimeFormatter as a private static final constant to prevent redundant object allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
ITJdbcTimestampPicosTestfailures in KokoroChanges
integration_test_continuous,standalone_it_continuous)Four assertions compared hardcoded UTC literals against
getString()on plainTIMESTAMPcolumns, which the driver renders in the JVM default time zone. The testsonly passed under a UTC JVM; the Kokoro VM runs
America/New_York, giving the observed12:34:56vs07:34:56mismatch.Added an
atJvmZone()helper that converts the UTC literal to the JVM zone, mirroringthe existing pattern in
ITBigQueryJDBCTest.validateGetString.TIMESTAMP(12)assertions are unchanged. Those values are returned as verbatim UTC strings and are
already zone invariant.
tpc_integration_tests_continuous)TPC backends reject the
TIMESTAMP(12)type parameter, so@BeforeAllfailed and thewhole class errored. Added a class-level
@Tag("disable_tpc")